Slick Forums

Implementing this into the texture loader is not a problem. How ever the PNG decoder does not know such formats and so graphics with this formats can't ever be loaded. I limited the enumerators I defined to those that can be used along with the PNG decoder.

Nitram

_________________
http://illarion.org

Always write I small test "BasicGame" Units test are totally useless for game developement since you always want to SEE something IMHO!

_________________
Current Projects:
Mr. Hat I
Vegan Vs. Zombies
Projects:
RadicalFish Engine - Build on top of Slick2D, Ideas, Bugs? Open an Issue ticket!

I plan to overload InternalTextureLoader with an internalFormat parameter, allowing users to specify the internal format even if the PNG/image data is using RGBA. Useful for forcing grayscale/luminance/etc. as well as specifying an internal format for off-screen images (i.e. not loaded from file).

Uh... careful there.
For the format of offscreen-images: all cool

Forcing the texture format of and image to something different: problems in most cases.
Doing such a thing requires to convert the textures BEFORE they are load into the textures. Else the byte data does not match.
Within limits the PNG decoder is able to perform such conversations. But not for any and all cases.

For example there is no equivalent in PNG pictures to the OpenGL mode "ALPHA" or the "INTENSITY" mode.

Nitram

_________________
http://illarion.org

With glTexImage2D we can provide two formats:
internalFormat - Used to specify how OpenGL should store the texture internally in vram
format - Used to specify what kind of format OpenGL should expect from the input ByteBuffer (I don't plan on changing this)

In other words, say we load an RGBA image from a PNG file. The format needs to match the PNG file, so it needs to be RGBA, but we can specify a different format to store the texture internally, such as GL_LUMINANCE, GL_RGB, or GL_RGB4 (taking up less memory and usually rendering more efficiently). It also provides a simple manner of converting to grayscale on the fly.

See the bottom of this page for details:
http://www.flipcode.com/archives/Advanc ... ping.shtml

I totally forgot about this one O.o

How ever the addition I created identifies the proper format. If setting the internalFormat should be done separately that doesn't have much to do with the stuff I wrote, does it?

Nitram

_________________
http://illarion.org

Nah, I don't think it affects your code. If other devs are in favour, I'll expose internalFormat and add INTENSITY/ALPHA as constants in the Format class.

If you want to load an ALPHA, LUMINANCE or INTENSITY image then just use a gray scale PNG.

_________________
TWL - The Themable Widget Library

Testcase is done and well... its working.



The pull for the required changes is requested.

Nitram

_________________
http://illarion.org